Conversation
If the user specifies `CC=...` then the previous fallback to `clang` would fail to work if `clang` wasn't in the path. This is quite likely on Windows in particular. Lets just drop the use of preprocessor on Windows and directly code the one constant that the preprocessor was handling.
Member
Author
|
@mati865 would it be possible to test this change? |
nagisa
force-pushed
the
nagisa/clang-cl
branch
2 times, most recently
from
378f44a to
eaab651
Compare
nagisa
force-pushed
the
nagisa/clang-cl
branch
from
eaab651 to
01c77f5
Compare
Member
|
I cannot test MSVC but updated rust-lang/rust#87680, thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user specifies
CC=...then the previous fallback toclangwould fail to work if
clangwasn't in the path. This is quite likelyon Windows in particular.
Lets just drop the use of preprocessor on Windows and directly code the
one constant that the preprocessor was handling.