Add stdsimd feature to allow_internal_unstable attribute in feature detect macros#1303
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Apr 29, 2022
Merged
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Member
Author
|
no idea what's up with that test failure... |
Member
|
This is probably caused by rust-lang/rust#95604, which lead to some issues with stdcall symbol name mangling. The potential fix is rust-lang/rust#96444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a blocker for rust-lang/rust#95956
That PR modifies the stability checking logic of rustc so that it additionally checks the stability of the path segments used to name an item, rather than only checking the stability of the item itself. This is necessary to allow
std::error::Errorto be moved into a new unstablecore::errormodule while still being available on stable via a re-export in the stablestd::errormodule.That change breaks the feature detection macros since they start encountering the
stdsimdunstable feature which is not explicitly mentioned in those macrosallow_internal_unstableattribute.