Replace some calls to pointer::offset with add and sub#1323
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Aug 22, 2022
Merged
Replace some calls to pointer::offset with add and sub#1323Amanieu merged 1 commit intorust-lang:masterfrom
pointer::offset with add and sub#1323Amanieu merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Member
Author
|
Seeing https://github.com/rust-lang/stdarch/runs/7917316301?check_suite_focus=true (doc only change) I think CI fails not because of my changes 🤔 |
Contributor
|
It looks fairly strange since nobody touched ppc64le in ages. I'll try to see if the problem is in qemu by running on real hardware ... |
lu-zero
reviewed
Aug 19, 2022
Contributor
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
The change looks fine though.
Member
|
CI should be fixed by #1326, can you rebase? |
Member
Author
|
Rebased 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#100746