Stabilize Wasm relaxed SIMD#1494
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. |
daxpedda
force-pushed
the
relaxed-simd
branch
from
44c4277 to
b654a03
Compare
crates/core_arch/src/wasm32/mod.rs
Outdated
|
|
||
| mod relaxed_simd; | ||
| #[unstable(feature = "stdarch_wasm_relaxed_simd", issue = "111196")] | ||
| #[stable(feature = "stdarch_wasm_relaxed_simd", since = "CURRENT_RUSTC_VERSION")] |
There was a problem hiding this comment.
Is CURRENT_RUSTC_VERSION how it's done in stdarch as well?
There was a problem hiding this comment.
No, you have to put in the actual version. Since stdarch is a submodule it doesn't get updated by the release time.
There was a problem hiding this comment.
Alright, will do that after the FCP in rust-lang/rust#117468.
There was a problem hiding this comment.
I tentatively assigned Rust v1.81 to make this mergable.
daxpedda
force-pushed
the
relaxed-simd
branch
2 times, most recently
from
3385000 to
7bbd5f7
Compare
|
This is currently based on #1523. |
daxpedda
force-pushed
the
relaxed-simd
branch
from
7bbd5f7 to
6946476
Compare
|
Rebased onto |
daxpedda
force-pushed
the
relaxed-simd
branch
from
6946476 to
6809048
Compare
|
@Amanieu I believe the current CI failure is not coming from this PR? |
|
This should fix itself when rust-lang/rust#121088 is merged. |
daxpedda
force-pushed
the
relaxed-simd
branch
from
6809048 to
f911445
Compare
|
I've put up #1528 for the aarch64 failure. |
daxpedda
force-pushed
the
relaxed-simd
branch
from
f911445 to
73576d7
Compare
|
I just noticed that there's a bunch of (aliased) "intrinsics" seemingly missing such as |
Do you mean adding |
|
Yeah that's done for the normal swizzle for example. And many other instructions. |
daxpedda
force-pushed
the
relaxed-simd
branch
3 times, most recently
from
371ccb0 to
325b8db
Compare
daxpedda
force-pushed
the
relaxed-simd
branch
from
325b8db to
c3cca2e
Compare
…wiser Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494 Closes rust-lang#111196.
…crichton Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494 Closes rust-lang#111196.
…ichton Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494 Closes rust-lang#111196.
Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: #111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494 Closes #111196.
5 participants
This is for rust-lang/rust#117468, which has to be accepted (but not merged) first before this can be merged.
I also changed some functions to use the proper LLVM instructions instead of their aliases, see #1396.
Additionally I added aliases to unsigned variants when appropriate (as is done in SIMD128).
Fixes #1396.
Depends on #1523.