std_detect: Tidying of slice length#1838
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Jul 3, 2025
Merged
Conversation
Collaborator
Contributor
Author
|
Hmm, CI is failing with a reason unrelated to this change itself. |
Contributor
|
Generally, changes should still be made here if possible. Certainly right now (CI doesn't run in the I have a possible fix for the issue here rust-lang/rust#143194, but that'll take at least a day to propagate to nightly and fix CI here. (that is of course one of the reasons to make stdarch a subtree: no more such breakage). |
We don't need to put the length of the `riscv_hwprobe` array into a variable. This commit removes that variable and gives the length of the output slice to the `__riscv_hwprobe` directly.
a4lg
force-pushed
the
riscv-linux-hwprobe-tidying-20250629
branch
from
a23fcf3 to
3c17d86
Compare
Contributor
Author
|
@folkertdev Thanks for letting me know (both about future contribution and current CI failures). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nothing more than a small tidying.
But since
stdarchmoved on to a Josh subtree, we (stdarchcontributors) can ask whether purestdarchchanges are still accepted through this repo.We don't need to put the length of the
riscv_hwprobearray into a variable.This commit removes that variable and gives the length of the output slice to the
__riscv_hwprobedirectly.