Remove std_detect dev dependency in core_arch#1843
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Jul 7, 2025
Merged
Conversation
f4326f0 to
0c1ef86
Compare
std_detect dev dependency in core_arch
Collaborator
folkertdev
reviewed
Jul 5, 2025
Contributor
folkertdev
left a comment
There was a problem hiding this comment.
changes to the detection macros should just happen in r-l/r then, right? At least when adding new target features that nicer anyway (in that case today we must wait for a nightly bump). It's only internal logic changes (which, as you say, are rare) that would get bitten by this, but then it should be easy enough to move such a PR over to r-l/r
Member
Author
Yes. Hopefully the whole of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
core_archloading theis_XYZ_feature_enabledmacros from the localstd_detectcrate, they are loaded from::std::archinstead. This means that nothing in this repository will depend onstd_detectanymore (except for tests, these will be ported later). The downside is thatcore_archwill need to wait for nightly std bumps to see changes in the detection macros, but I assume that should be rare.This is one of the steps required to move
std_detectfully intorust-lang/rust.