Skip to content

Conversation

@folkertdev
Copy link
Contributor

implementation: #1938
tracking issue: rust-lang/rust#147555

I think we should stabilize this intrinsic. The jsconv feature itself has been stable since 1.60.0. The intrinsic works as expected in ruffle, see ruffle-rs/ruffle#22138 (comment).

API surface

The stdarch_aarch64_jscvt feature contains one function:

Floating-point JavaScript convert to signed fixed-point, rounding toward zero

#[target_feature(enable = "jsconv")]
pub fn __jcvt(a: f64) -> i32;

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@folkertdev
Copy link
Contributor Author

@adamgemmell (or someone else from arm), could you give the changes to intrinsics_data/arm_intrinsics.json from #1938 a once-over just to make sure that is all correct?

@adamgemmell
Copy link
Contributor

adamgemmell commented Jan 13, 2026

The JSON looks good to me. This intrinsic isn't part of Neon but it's fine for the JSON to say that to avoid having to edit some of stdarch's tests.

As was pointed out on the original rust PR the link to our documentation 404s, but I'll see if we can get this added to that page.

@dtolnay dtolnay changed the title stabilize __jscvt stabilize __jcvt Jan 13, 2026
@traviscross traviscross added I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. T-lang Relevant to the language team. labels Jan 13, 2026
@traviscross
Copy link
Contributor

@rfcbot fcp merge lang

(Doing the lang-side of the FCP from rust-lang/rust#147555; will check the lang boxes already checked there.)

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Jan 13, 2026

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This PR / issue is in pFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 13, 2026
@rust-rfcbot
Copy link
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. label Jan 14, 2026
@traviscross
Copy link
Contributor

cc @RalfJung

@traviscross traviscross changed the title stabilize __jcvt Stabilize __jcvt Jan 14, 2026
@nikomatsakis
Copy link

@rfcbot reviewed

@traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This PR / issue is in pFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. T-lang Relevant to the language team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants