fix: match rulesets by branch pattern#2212
Open
amustaque97 wants to merge 4 commits intorust-lang:mainfrom
Open
fix: match rulesets by branch pattern#2212amustaque97 wants to merge 4 commits intorust-lang:mainfrom
amustaque97 wants to merge 4 commits intorust-lang:mainfrom
Conversation
dc38f6a to
1ca19d0
Compare
Dry-run check results |
1ca19d0 to
adac3d3
Compare
Member
|
looks good. I did a few small changes. Testing in #2232 |
ubiratansoares
approved these changes
Jan 27, 2026
Contributor
ubiratansoares
left a comment
There was a problem hiding this comment.
Side note from my side : perhaps we could have a follow-up PR to add some snapshot tests covering common scenarios around rulesets, eventually having #2211 as test case too 🙂
Member
|
Ahmed, this is the diff of the dry run: It looks very verbose. Also, is it normal that it is deleting the ruleset and recreating it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2211
Summary
Improves ruleset diffing to match by branch pattern instead of name (enabling in-place updates rather than delete/recreate)