Update discriminant-elision optimization on Option-like enums#149
Merged
RalfJung merged 12 commits intorust-lang:masterfrom Jul 18, 2019
Merged
Update discriminant-elision optimization on Option-like enums#149RalfJung merged 12 commits intorust-lang:masterfrom
RalfJung merged 12 commits intorust-lang:masterfrom
Conversation
RalfJung
reviewed
Jun 23, 2019
RalfJung
reviewed
Jun 23, 2019
Member
|
This still does not specify, though, that transmuting between e.g. EDIT: Oh I see, that RFC pretty much fixes the |
Co-Authored-By: Ralf Jung <post@ralfj.de>
RalfJung
reviewed
Jun 24, 2019
RalfJung
reviewed
Jun 24, 2019
Co-Authored-By: Ralf Jung <post@ralfj.de>
RalfJung
reviewed
Jun 25, 2019
RalfJung
reviewed
Jun 25, 2019
RalfJung
reviewed
Jun 25, 2019
RalfJung
reviewed
Jun 25, 2019
Co-Authored-By: Ralf Jung <post@ralfj.de>
Co-Authored-By: Ralf Jung <post@ralfj.de>
Contributor
Author
|
The last commit hyperlinks everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the discriminant-elision optimization on option-like enums with the semantics specified in rust-lang/rust#60300
The main change is requiring that option-like enums do not have any explicit
#[repr(...)]attributes.