Allow appending neighbor entries, which is useful with certain kernel drivers#61
Open
mepholic wants to merge 1 commit intorust-netlink:mainfrom
Open
Allow appending neighbor entries, which is useful with certain kernel drivers#61mepholic wants to merge 1 commit intorust-netlink:mainfrom
mepholic wants to merge 1 commit intorust-netlink:mainfrom
Conversation
… drivers This is my attempt at fixing issue rust-netlink#60 on the Github project.
Member
|
Please do similar stuff like #57 by using a builder. The builder approach is collecting all configurations and generate the final netlink message at final call of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing issue #60
I've left more commentary on the issue, and spent some time reading kernel sources. I think this solution should be sufficient for now, but I don't know if my approach at making REPLACE override APPEND if both are specified is a good idea. I wasn't sure what the project's guidelines were on error handling, and if generating an error from the library itself was acceptable, or if having netlink complain (or possibly silently do something weird) is preferred.
I've tested the code for my particular use case, and it works great!
If anybody has any thoughts on this implementation, I'd be happy to attempt to solve this another way. 😀