Add git submodule init#46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the build process by ensuring that required git submodules are initialized and updated before building, particularly when the build feature is enabled.
This helps in cases where the crate is obtained from a normal clone or through git = "..." in Cargo, where submodules may not have been fetched in advance. Without them, the native sources required by the build are unavailable, and the failure only shows up later during compilation.
For
*-syscrates, handling bundled native sources in the build step is a common approach, since it makes the crate more self-contained and avoids extra setup requirements for downstream users.