Make WrappedObject Send + Sync using RwLock#307
Open
martin-hughes wants to merge 1 commit into
Open
Conversation
This changes the WrappedObject interface, so will need a version bump. The aim is to remove the unsafe Send and Sync implementations, to: - Make sure WrappedObject really is Send / Sync - Make it easier for users to use WrappedObject in a thread-safe way.
martin-hughes
commented
Jun 20, 2026
| use acpi::aml::{Interpreter, object::WrappedObject}; | ||
| use static_assertions::assert_impl_all; | ||
|
|
||
| assert_impl_all!(Interpreter<NullHandler>: Send, Sync); |
Contributor
Author
There was a problem hiding this comment.
I just noticed I hadn't taken this line out - it'll always be true, as it stands (due to the unsafe impl blocks).
Reason it's here is that I've been experimenting with how to remove those unsafe impl blocks from Interpreter - my feeling is they make it too easy to make other mistakes (such as in #306 where the allocator may not be Send + Sync) but I haven't got all the way there yet.
I'll try and remember to take out that test with any updates you want me to make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is inspired by the same reason I asked #302 - I'd like to be much more sure
acpiis actually safe. It's a suggestion really, to see if you like it @IsaacWoods. Thoughts?There are, IMO, at least a couple of things I don't like about
WrappedObject.WrappedObjectin an unsafe way despite theunsafe implstatements, andSo with that in mind I've generated this PR.
I'm not sure if you have any feelings about AI generated code @IsaacWoods so for full disclosure - the heavy lifting here was done by Claude's Opus 4.8 model based on my prompts and questions.
I've then refined, reviewed, edited and tested it - no vibe coding here! But I can imagine you might think of a better way to achieve the same goal, in which case I'm happy to make a second attempt.