support higher half position independent kernels#289
Merged
phil-opp merged 3 commits intorust-osdev:mainfrom Jan 9, 2023
Merged
support higher half position independent kernels#289phil-opp merged 3 commits intorust-osdev:mainfrom
phil-opp merged 3 commits intorust-osdev:mainfrom
Conversation
Co-Authored-By: Philipp Oppermann <dev@phil-opp.com>
Co-Authored-By: Philipp Oppermann <dev@phil-opp.com>
Freax13
force-pushed
the
higher-half-pic
branch
from
69c9246 to
ae17796
Compare
Member
Author
|
It happened again, GitHub automatically closed this pr when #283 was merged. |
Member
|
Sorry about that! Maybe the automatic PR base change does not work across forks? For now I disabled the automatic deletion of merged branches for this repo to avoid this issue in the future. |
phil-opp
approved these changes
Jan 9, 2023
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Sorry for the late review. Thanks a lot for this PR, the code is really nice!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support for loading position independent kernels with a base address other than 0.
Currently the base address is ignored. In the future, we could try to map the kernel at it's base address if it's non zero. Doing this right now would be difficult because we don't have accurate book keeping on what addresses have already been allocated (See #239). I propose we take another look at this once finer granular ASLR is implemented (finer granular ASLR requires more accurate book keeping).
Closes #285