Use traits for register and uart#39
Open
ChocolateLoverRaj wants to merge 2 commits intorust-osdev:masterfrom
Open
Use traits for register and uart#39ChocolateLoverRaj wants to merge 2 commits intorust-osdev:masterfrom
ChocolateLoverRaj wants to merge 2 commits intorust-osdev:masterfrom
Conversation
Contain breaking changes Advantages: - Reduces the amount of code - Lets people using this library use a uart with `dyn Uart16550` - It will be very easy to add another method in addition to port and mmio
Member
|
will be superseded by #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Contain breaking changes
Advantages:
dyn Uart16550Tested the port with qemu and tested the mmio on a real computer.