Closed
Conversation
Member
|
Hi, thanks for the PR! The problem with implementing I hope that rust-lang/rust#53645 is merged soon. It implements const generics, which means that we could create a |
Author
|
Ah I see, I was trying to do something similar with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. This PR makes the
Volatilestruct derive Copy. I'm not sure whether this will have any negative or unintended consequences.To clarify what this is needed for, I am currently looking to improve some of the VGA text buffer code in Philipp Oppermann's blog_os. This PR allows an optimisation to be made for which I will send a PR there too.