Conversation
|
Hi @chantra, thanks for the PR, but based on the build outputs: https://github.com/rust-pcap/pcap/actions/runs/11135749919/job/32117440201?pr=369 you will need to ammend the code as well. Let me know if you need help. You can ignore the lints as that is currently also a problem on main. |
|
Thanks @Wojtek242 , I will update the PR accordingly. I think that now that you authorized this PR to run the GitHub actions, update should do too, so this may help. I don’t have a windows setup handy, but I am fairly confident I should be able to cross-compile easily with cargo. |
chantra
force-pushed
the
bump_windows_sys
branch
from
73b8d0c to
afaadf1
Compare
|
@Wojtek242 ok, it seems I can't get the CI to run without approval. This now builds with: |
Since windows-sys-0.45.0, `windows_sys::Win32::Networking::WinSock::ADDRESS_FAMILY` are u16 instead of u32.
windows_sys::Win32::Foundation::HANDLE type has changed since microsoft/windows-rs@d331301 update the tests accordingly.
chantra
force-pushed
the
bump_windows_sys
branch
from
afaadf1 to
f917874
Compare
|
I apologize for PR-sniping you; I didn't see this PR before making #378 Your updated is incomplete -- it's missing fixes that are unveiled by the |
Thanks @qrnch-jan for the heads up. I am totally fine with your PR making it through. |
Summary: This was discovered during D72270980 - the current `pcap` patch points to [#369](rust-pcap/pcap#369) that was abandoned in favor of [#378](rust-pcap/pcap#378). It also looks like the newer PR contains more fixes. Reviewed By: capickett Differential Revision: D72417065 fbshipit-source-id: 9da5febc967c621d693e4382994d8ddc670b9630
Summary: This was discovered during D72270980 - the current `pcap` patch points to [#369](rust-pcap/pcap#369) that was abandoned in favor of [#378](rust-pcap/pcap#378). It also looks like the newer PR contains more fixes. Reviewed By: capickett Differential Revision: D72417065 fbshipit-source-id: 9da5febc967c621d693e4382994d8ddc670b9630
3 participants
Simple windows-sys version bump to the latest published crate version.