feat(login): add password visibility and clean up block titles#20
Merged
max-wells merged 1 commit intorust-ui:mainfrom Apr 12, 2026
Merged
Conversation
The login blocks now behave more like real forms: email/password fields include proper autocomplete hints, password inputs enforce a minimum length, and each layout gets a show/hide password toggle.\n\nI also updated the login and sidenav block titles so the registry labels match what the blocks actually render, then added regression tests in block_entry to keep those mappings (and the password field expectations) from drifting.
max-wells
approved these changes
Apr 12, 2026
Contributor
max-wells
left a comment
There was a problem hiding this comment.
Great contribution — clean implementation, tests included, and good attention to UX details (autocomplete, minlength, password toggle). Happy to merge this in. Thanks @krishpranav!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Login blocks looked polished, but they were still missing a few practical details users expect in real auth forms.
This patch closes that gap and keeps block naming aligned with what each block actually renders.
What changed
login01,login02,login03, andlogin04autocomplete="username"on login email inputsautocomplete="current-password"andminlength=8on password inputsInputAPI to supportautocompleteandminlengthValidation
Screenshot
Closes #10