This repository was archived by the owner on Oct 30, 2019. It is now read-only.
Remove futures_api feature flag#17
Merged
yoshuawuyts merged 1 commit intorustasync:masterfrom Apr 26, 2019
Merged
Conversation
yoshuawuyts
approved these changes
Apr 26, 2019
Collaborator
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
This looks excellent, thanks!
Collaborator
|
@marcelbuesing I'm debating whether or not to publish a new release for all crates based on this patch, or wait for more patches to land before doing a release. Do you have a preference? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all occurrences of the futures_api feature flag.
Motivation and Context
Since rust-lang/rust#59739 has been merged it should no longer be necessary to specify the futures_api feature flag. The minimal nightly version required is
rustc 1.36.0-nightly (e305df184 2019-04-24).Building the runtime crate using this nightly version otherwise shows:
FYI: Also see this pull request:
https://github.com/rust-lang-nursery/futures-rs/pull/1546/files
Types of changes
I think this in a way a breaking change as it changes the error behavior of rust stable and nightly versions that are older than nightly 2019-04-24. Nevertheless since the features async_await and await_macro are not yet stabilized in stable < 1.36 the error that nightly rust is required should still be shown, just not specifically mentioning the futures_api feature.