provide with_platform_verifier_and_extra_roots extension function#204
provide with_platform_verifier_and_extra_roots extension function#204conradludgate wants to merge 1 commit intorustls:mainfrom
Conversation
|
No extra roots on Android... maybe an extension trait method that yields some kind of builder which only offers to set extra roots on non-Android? |
0bd0573 to
c1de987
Compare
|
The android/ios tests failing seems to be unrelated. The semver error is correct, but I feel like it is not significant here - no one should be using |
This comment has been minimized.
This comment has been minimized.
c1de987 to
88108de
Compare
complexspaces
left a comment
There was a problem hiding this comment.
This looks good to me. I agree the technical semver breakage shouldn't be important. I have a really hard time seeing anyone using the extension traits in their own type declarations since there's only one implementation of each anyway.
|
I assume if we merge this the |
|
Probably only after we release. |
|
Should we go ahead and merge this and then release next week? We have enough changes in |
|
Sounds good to me. |
Fixes #202