ci: use --locked for MSRV cargo-ndk install#38
Merged
cpu merged 1 commit intorustls:mainfrom Oct 14, 2023
Merged
Conversation
A transitive dependency of `cargo-ndk`, `regex-automata`,increased its MSRV and so installing `cargo-ndk` at version 2.12.7 breaks in the MSRV CI task unless we use the pinned `Cargo.lock` version, or upgrade our MSRV in turn.
djc
approved these changes
Oct 13, 2023
complexspaces
approved these changes
Oct 13, 2023
Collaborator
complexspaces
left a comment
complexspaces
left a comment
There was a problem hiding this comment.
IIRC using --locked for CI is best practice anyway, so this looks good 👍
Collaborator
|
Am I the only one seeing the "Merge without waiting for requirements to be met" box in GitHub's UI? This looks like a previously unknown side effect of the branch protection experiments in #33. I guess that needs revisited, again. |
Member
Author
I can confirm I'm seeing the same thing.
Ah bummer. I can take a closer look ~Monday. In the mean time I'll just break-glass merge to fix the CI job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transitive dependency of
cargo-ndk,regex-automata,increased its MSRV and so installingcargo-ndkat version 2.12.7 breaks in the MSRV CI task unless we use the pinnedCargo.lockversion, or upgrade our MSRV in turn.See #30 for previous struggles related to
cargo-ndkand maintaining a MSRV of 1.64.Resolves #37.