tal/str: don't loop in tal_fmt (et al.)#121
Open
whitslack wants to merge 1 commit into
Open
Conversation
There is no need to loop. Just ask vsnprintf how many bytes it needs, and size your buffer accordingly. FYI, the POSIX documentation for vsnprintf() states: > If the value of n is zero on a call to snprintf(), nothing shall be > written, the number of bytes that would have been written had n been > sufficiently large excluding the terminating null shall be returned, > and s may be a null pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to loop. Just ask
vsnprintfhow many bytes it needs, and size your buffer accordingly.FYI, the POSIX documentation for
vsnprintf()states:I'm sorry that GitHub doesn't display the diff sensibly. (Git does.) It's easier to grok if you just hit View File. The code is very straightforward.