Fix EvtRender buffer size calculations and null terminator handling#9
Open
yoavwizstein wants to merge 1 commit intorustysec:masterfrom
Open
Fix EvtRender buffer size calculations and null terminator handling#9yoavwizstein wants to merge 1 commit intorustysec:masterfrom
yoavwizstein wants to merge 1 commit intorustysec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EvtRender API reports BufferUsed in bytes, but the old code had two bugs that partially cancelled each other out:
buffer_used was used directly as the element count for a Vec, allocating a buffer 2x larger than needed.
buf.len() (element count) was passed as BufferSize, which expects bytes.
The net effect was that EvtRender received the correct byte size by accident, but the oversized buffer produced trailing null characters in every rendered event string.
This change:
Correctly converts buffer_used from bytes to u16 element count for allocation
Passes buf.len() * size_of::() as BufferSize (bytes, per the API contract)
Strips the null terminator at the u16 buffer level