fix(sensing-server): accept NUL-padded safetensors headers (#894)#1151
Open
jmunozro wants to merge 1 commit into
Open
fix(sensing-server): accept NUL-padded safetensors headers (#894)#1151jmunozro wants to merge 1 commit into
jmunozro wants to merge 1 commit into
Conversation
The published ruvnet/wifi-densepose-pretrained/model.safetensors pads its
JSON header with NUL bytes rather than the spec's spaces. serde_json::from_slice
requires the whole slice to be one JSON value, so it parsed the object and then
errored on the trailing \0s ("trailing characters at line 1 column 1462"), and
--convert-model / the in-memory --model auto-convert both failed.
Parse the header with a streaming Deserializer that reads the first JSON value
and ignores trailing padding. Centralized in safetensors_to_rvf, so both the
CLI converter and load_or_convert_model are fixed. Adds a regression test that
reproduces the NUL-padded header.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published ruvnet/wifi-densepose-pretrained/model.safetensors pads its JSON header with NUL bytes rather than the spec's spaces. serde_json::from_slice requires the whole slice to be one JSON value, so it parsed the object and then errored on the trailing \0s ("trailing characters at line 1 column 1462"), and --convert-model / the in-memory --model auto-convert both failed.
Parse the header with a streaming Deserializer that reads the first JSON value and ignores trailing padding. Centralized in safetensors_to_rvf, so both the CLI converter and load_or_convert_model are fixed. Adds a regression test that reproduces the NUL-padded header.