Add Print/PrintLine overloads for SystemTime#59
Open
its-mohitkumar-7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Print(value: SystemTime)/PrintLine(value: SystemTime)toPrint.rux.Problem
UtcTime()/LocalTime()returnSystemTime, butPrint/PrintLinehad no overload for it:
Fix
Src/Print.rux, plusimport Std::Time::SystemTime;.PadTime2/PadTime3for zero-padding —nested functions currently fail on the ELF linker.
YYYY-M-DD HH:MM:SS.mmm.Scope
Only tested on Linux.
SystemTimeis a different type per target, soI can't say if this works on Windows/macOS/BSD without checking there too.
Testing
Manually verified on Linux against all
Std::Timefunctions via bothPrintandPrintLine.LocalTime()output matchesUtcTime(), asexpected since it currently just forwards to it on Linux.