Add Kahan summation overloads to Std::Math#60
Open
its-mohitkumar-7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds two overloads of
KahanSumtoStd::Math:KahanSum(float64...) -> float64KahanSum(float32...) -> float32These functions implement the Kahan summation algorithm (compensated summation) to reduce floating-point error accumulation when summing multiple values.
Notes
Full automated verification was not possible at this time because some math utility functionality (such as complete absolute-difference helpers) is still under development in the standard library. Additional validation and unit tests can be expanded once those utilities are available.
The implementation itself was manually verified against expected numerical results for a variety of floating-point edge cases.