Skip to content

Component Traversal#26

Open
MartinW wants to merge 2 commits intorwapp:masterfrom
MartinW:feature/ComponentTraversal
Open

Component Traversal#26
MartinW wants to merge 2 commits intorwapp:masterfrom
MartinW:feature/ComponentTraversal

Conversation

@MartinW
Copy link
Contributor

@MartinW MartinW commented Mar 4, 2020

Suggested addition to the Traversal Order screen.

Adds a Component Traversal view as a container. Adds a TileView which demonstrates setting the accessibility label for a view, to allow the user to navigate the app easier.

This sets an accessibility label and accessibility trait to the view. It also disables the accessibility element for the UILabels.

@rwapp
Copy link
Owner

rwapp commented Apr 26, 2020

Thanks Martin. This is a great addition, I apologise its taken so long for me to take a look.

Two minor improvements if you have the chance please.

  1. two of the tiles have a default background colour still so they look a little weird with dark mode enabled.
  2. Setting the views to have a fixed height means they don't work with dynamic text sizes. Ideally this screen should be in a scroll view, but it looks like I missed it. I think using a scroll view and a bottom constraint of >= 20 should make these work ok without a fixed height constraint?

I really appreciate your input here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants