fix: Exclude desktop widgets from tile-all and cascade-all#1707
Open
claudeaceae wants to merge 1 commit intorxhanson:mainfrom
Open
fix: Exclude desktop widgets from tile-all and cascade-all#1707claudeaceae wants to merge 1 commit intorxhanson:mainfrom
claudeaceae wants to merge 1 commit intorxhanson:mainfrom
Conversation
Filter out windows belonging to Dock, WindowManager (Stage Manager), and Notification Center (which hosts desktop widgets on macOS Sonoma+) in getAllWindowElements(). This prevents desktop widgets from being included in multi-window operations like tile-all, cascade-all, and reverse-all. Fixes rxhanson#1701 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thanks! I'll test this out in the next day or so. |
Author
|
Sounds good, thanks for taking a look! Let me know if you run into any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAllWindowElements()getWindowInfo()(line 323) which excludes Dock and WindowManager for cursor-based window detectionDetails
The root cause:
getAllWindowElements()extracts unique PIDs fromCGWindowListCopyWindowInfo(which uses.excludeDesktopElements), then queries the Accessibility API for all windows belonging to each PID. If the Notification Center process has any visible window in the CG window list, all of its windows — including desktop widgets — are returned and subsequently included in multi-window operations.The fix adds a process name filter before PID extraction, excluding known system processes that don't have user-tileable windows. This affects all callers of
getAllWindowElements():MultiWindowManager(tile-all, cascade-all, tile-active-app, cascade-active-app)ReverseAllManager(reverse-all)TodoManager(todo mode filtering)Test plan
tile-allno longer repositions desktop widgets on macOS Sonoma+cascade-allno longer includes desktop widgetsreverse-allno longer includes desktop widgetsFixes #1701
🤖 Generated with Claude Code