Skip to content

Fix bug on iOs which prevented tooltip closing. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldanet wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bug on iOs which prevented tooltip closing. #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd5d24
Set hover state to false when touching outside
ldanet Jun 19, 2018
c0e677e
Make comment consistent
ldanet Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/react-accessible-tooltip/src/Tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,20 @@ class Tooltip extends Component<TooltipProps, TooltipState> {
activeElement instanceof Element &&
target instanceof Element &&
this.container instanceof Element &&
!this.container.contains(target) && // touch target not a tooltip descendent
this.state.isFocused // prevent redundant state change
!this.container.contains(target) // touch target not a tooltip descendent
) {
this.setState({ isFocused: false });
activeElement.blur();
// prevent redundant state change
if (this.state.isFocused) {
this.setState({ isFocused: false });
}
// prevent redundant state change
if (this.state.isHovered) {
this.setState({ isHovered: false });
}
// don't blur active element if outside
if (this.container.contains(activeElement)) {
activeElement.blur();
}
} else if (
activeElement instanceof Element &&
target instanceof Element &&
Expand Down