(via ryandens): Remove manual Windows path quoting in JavaForkOptionsConfigurer.asArgume#373
Merged
ryandens merged 7 commits intoJul 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Windows build issues by addressing path quoting and script execution problems.
Changes
Remove manual Windows path quoting in JavaForkOptionsConfigurer
asArguments()methodOperatingSystemimportFix Windows CI build script execution
.github/workflows/gradle.ymlto conditionally use the correct Gradle wrapper script based on platformgradlew.baton Windows and./gradlewon Unix systemsNote
Macroscope: Fix It For Me
Activity
Currently: Not merged: unknown mergeable state
Previously
Note
Fix generated start scripts to use platform-appropriate app home variable on Windows
Platformenum gains anappHomeVarproperty ($APP_HOMEon Unix,%APP_HOME%on Windows), used byJavaagentAwareStartScriptGenerator.FakeTransformerwhen building-javaagentarguments.$APP_HOME, producing broken paths on Windows; they now use%APP_HOME%with backslash separators on Windows.gradlew.baton Windows and assert OS-appropriate script content.Macroscope summarized e2a04de.