(via ryandens): Fix Windows batch script: use separate quoted tokens for multiple javaag#374
Merged
ryandens merged 1 commit intoJul 6, 2026
Conversation
e1367ab to
d9ac29b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows batch script generation to correctly handle multiple
-javaagentarguments.Changes
Modified the
Fake.write()method to use platform-aware separators when joining multiple javaagent arguments:" "(close quote, space, open quote) as the separator so each-javaagentoption becomes its own quoted token in the batch scriptThis ensures proper argument parsing on Windows where multiple javaagent options were previously being concatenated incorrectly.
Note
Macroscope: Fix It For Me
Activity
Currently: Merged by ryandens
Previously
Note
Fix Windows batch script to use separate quoted tokens for multiple
-javaagentoptionsOn Windows, multiple
-javaagentoptions in the generated start script were not properly separated, causing launch failures. The fix passes the currentPlatformto theFakewriter inJavaagentAwareStartScriptGenerator, which then joins-javaagententries with" "(close-quote, space, open-quote) on Windows so each agent becomes a separately quoted token. Non-Windows behavior (space-separated) is unchanged.Macroscope summarized d9ac29b.