Upgrade to support 15.5 without warnings#5
Open
coryhouse wants to merge 1 commit intoryanflorence:masterfrom
Open
Upgrade to support 15.5 without warnings#5coryhouse wants to merge 1 commit intoryanflorence:masterfrom
coryhouse wants to merge 1 commit intoryanflorence:masterfrom
Conversation
|
lol I made the same pull request without checking to see if someone else did it first. I like your's better, as it uses ES6 modules instead of the shim. I'll leave mine up for now, but will close once yours is merged (assuming @ryanflorence is still around) |
3 tasks
|
I just made the same one too. Oops! Doesn't look like anyone is looking at these. @ryanflorence, are you still maintaining this at all? |
|
@MarkRabey I ended up switching to react-document-title. Same idea, and it's been updated to support React 15.5.x |
|
@ryanflorence any chance to see this merged? |
|
as far as I can see, react-document-title doesn't sadly support calculating the title using the parent title 😕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are still throwing a propType warning:
ERROR: 'Warning: You are manually calling a React.PropTypes validation function for therenderprop onTitle.I don't see anything off-hand. Perhaps you do?
Anyway, no warnings at runtime, tests are passing, and it's working fine in my tests.
This is to resolve #4.