Remove initial newline from show()#129
Open
thirtysixbananas wants to merge 1 commit into
Open
Conversation
On Base.show() the print shouldn't start with a \n
For example, in the following code the last line does not display properly in vscode:
```julia
import ARCHModels
rets = rand(Float64, (100,5))
volspec = ARCHModels.CCC(Statistics.cor(rets), Float64[], [ARCHModels.GARCH{1, 1}([1., .9, .05]) for _ in 1:2])
model = ARCHModels.MultivariateARCHModel(volspec, rets)
```
Owner
|
Can you make sure the tests and doctests pass? |
Author
|
Sorry, this was a drive-by commit and I never looked at it again until now. Looking at it now, I'm confused by this [1]. What is happening here? Why is it testing that the show starts with a certain string, which is different depending on the version? Do you want to test that the show changed with version, or that the type changed with version? [1] ARCHModels.jl/test/runtests.jl Line 21 in 60c198f |
Owner
|
That's because of a change in Julia itself to the way parameterized types are displayed. |
Author
|
Ok, but why does it need to be tested? |
Owner
|
Well, I guess I aim for maximum test coverage :) |
Author
|
Haha. Are you open to be convinced that this is a bad idea? :-) |
Owner
|
Probably not ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Base.show() the print shouldn't start with a \n
For example, in the following code the last line does not display properly in vscode: