Skip to content

Sorcha/dev/review export#1

Merged
s6sebusc merged 2 commits into
s6sebusc:export_membersfrom
enssow:sorcha/dev/review-export
May 26, 2026
Merged

Sorcha/dev/review export#1
s6sebusc merged 2 commits into
s6sebusc:export_membersfrom
enssow:sorcha/dev/review-export

Conversation

@enssow

@enssow enssow commented May 22, 2026

Copy link
Copy Markdown

Description

Suggestions, please feel free to copy over seperately rather than merging the PR as some of the changes are just aesthetic/from linitng. The main suggestions are to add mem to the config so that it can be adjusted more flexibly and we don't have to continuously add new coords to the functions themselves. Let me know what you think!

Issue Number

Closes ecmwf#2247

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions Bot added the eval label May 22, 2026
@s6sebusc s6sebusc merged commit 3f6e9ac into s6sebusc:export_members May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants