feat: update to Actsv44 by osbornjd · Pull Request #44 · sPHENIX-Collaboration/acts

osbornjd · 2026-03-06T14:11:58Z

PR #44 for updating to Actsv44... it was destiny

In the ESC24 school I learned, that `noexcept` on special member functions, especially on move assignment and move construction can be very impactful on performance with `std::vector`. The reasons seems to be the strong exception garantuees of `std::vector`: If the move construction is not `noexcept` it falls back to copy, because it is required to be able to restore the initial state in case of failure of an operation. See for this e.g. the quickbench result on a dummy `String` implementation: https://quick-bench.com/q/5CG81CYyOUm7xSa9ClbyLiPj7SY I won't have any effect on source links I think because of SBO, but in general would be useful to have here I think.  ## Summary by CodeRabbit - **New Features** - Enhanced exception safety for the `AnyBase` class. - Improved debugging capabilities with verbose output for allocation and deallocation operations. - **Bug Fixes** - Updated method signatures to ensure consistent exception handling based on allocation tracking settings.

…rial (acts-project#4441)

Makes use of the `zip` function of the `SpacePointContainer2` which allows iterating on unrolled individual column entries. The advantage of this is that we do not need to add the index all the time but rather move multiple iterators along. Potentially this is also easier for the compiler to reason about than operating on the proxy.

…cts-project#4442) Previously, the tracking geometry visitor would call the `visitSurface` method for child surface (sensitive + passive) as well as portals (and boundaries). With this PR, it does not do that anymore. Also includes a fix to the Gen3 SVG conversion which relied on this behavior.

…#4446) Avoids code duplication. This is also how the original seeding code looks like which makes it easier to compare.

- Introduce new helper functions to calculate factorial or the sum of N integers - Introduce binomial coefficient calculation function - Introduce new helper function to calculate a direction vector from the tangents of the x to the z & from the tangent of the y to the z axis - Implementation of the Legendre & Chebychev polynomials avoiding the useage of the recursion formulas. Other implementations, I've seen make explicit use of the recursion formula which is kind of slow if higher order polynomial order functions are evaluated frequently. This implementation calcualtes the coefficients of the first 10 orders & their associated derivatives at compile time. - Introduce helper functions to intersect lines & planes, also to calculate the signed distance between two lines

Find vecmem before setting up the libraries that need it. So that a pre-built vecmem installation could be used together with algebra-plugins and detray being built by this project.

This is the cherry-picked version of acts-project#4315 and introduces a common alignment decorator that can be used with different detectors in the Examples framework.

…ementation (acts-project#4447) Uses `Boost.Mp11` to unroll templates of the `DoubletSeedFinder` implementation. The doublet finding is quite hot and at the same time supposed to be flexible. With increasing flexibility we add more and more code to a hot function which will slow down other use cases. The proposed alternative here is to use N template switches which all get instantiated and dispatched during runtime. The implementation here decides on the appropriate function based on the config once on instantiation and then uses virtual dispatch into the appropriate one.

)

…oject#4456) In ePIC we noticed (upon upgrading to v39) that our material map json geometry did not get the correct `AxisPhi` and `AxisZ` binning directions (instead we got `AxisX`). This turned out to be due to the incorrect parsing of the `binPhi` and `binZ` fields. In particular, the iterator `it` in `s_legacyBinningValueNames` cannot be compared to `s_axisDirectionNames.begin()` (a different vector) to get the index. This PR introduces an early return when the `name` is found in the `s_legacyBinningValueNames` vector. I confirmed that with this fix the json output indeed changes `CylinderBounds` from: ```json "binUtility": { "binningdata": [ { "bins": 144, "max": 3.1415927410125732, "min": -3.1415927410125732, "option": "closed", "type": "equidistant", "value": "AxisX" }, { "bins": 10, "max": 0.0, "min": 0.0, "option": "open", "type": "equidistant", "value": "AxisX" } ] }, ``` to ```json "binUtility": { "binningdata": [ { "bins": 144, "max": 3.1415927410125732, "min": -3.1415927410125732, "option": "closed", "type": "equidistant", "value": "AxisPhi" }, { "bins": 10, "max": 0.0, "min": 0.0, "option": "open", "type": "equidistant", "value": "AxisZ" } ] }, ``` Note: this is an error that one could argue could/should have been caught by static analysis. A quick search of `std::distance` calls on reused iterators within the same function did not turn up any other instances (in the v39.2.0 source tree that I was looking at).

This helper can be instantiated from a unit test. It will look up the test name and create a temporary directory that can be used during the test.

Fix missing tag by explicitly fetching. I have a more correct fix in the pipeline.

…acts-project#4450) With acts-project#4447 the sorting requirement of the `DoubletSeedFinder` becomes an option. The same can now be done for the `BroadTripletSeedFinder`. This generalizes the use of the `BroadTripletSeedFinder` and will be beneficial for the module map approach.

…ct#4458) The retry logic currently only works for HTTPError. I'm observing URLError in CI now, so I'm including this exception in the retry logic as well now.

) This allows it to take better formatting decisions for custom functions.

- SVG drawing uses it to draw composites as well - Add a comment to indicate that the composite conversion in some cases (edge) does not produce a grid portal

…derivative (acts-project#4455) - Introduce helper functions to map the indices of a matrix to an unrolled vector - Introduce the LineWithPartials class which provides a line as function of four parameters and its associated derivatvies

…ject#4457) The goal is to cover as many compilers as possible, so now we test on clang16, gcc13, gcc14, gcc15 and clang19 across LCG 106a, 107, 107a and 108

This function does not mutate the state of the `SurfaceArray` and therefore marked as `const`

Since recent container upgrade we are seeing build failures. This allows to bypass the erroneous process until we figure out a proper fix.

The previous attempt failed, because I did not explicitly ask the check to include the C++20 compiler flag, which failed in some conditions.

Also adds some tests to ensure ProxyAccessor can be constexpr created.

…#4466) - Fix phi binning so grid positions align with surface positions - `disk` -> `disc`

Enable the AMVF to deal with multiple vertex seeds at a time. We suspect that this is a limitation for nearby vertices as right now the AMVF will follow a greedy procedure and potentially merge these candidates during finding.

…s-project#4691) I've added an environment variable `ACTS_SOURCE_DIR` to the `this_acts.sh` script for harmonize the setup scripts

Broken out of acts-project#4607

…-project#4660) I double-checked the mathematical implementation of the fitter, including sign handling and the computation of the fit constants. I also modified the initial estimation of t0, which improved both the robustness and performance of the fit.

…t#4683) Add particle propagation to perigee. The`writeHelixParameters` config flag toggle writing track parameters at the perigee instead of the ones at production vertex. Neutral particles are propagated with a linear track hypothesis.

This PR enables the reading of the detray detector from json files.

Broken out of acts-project#4607

Currently, at configure time, we will generate a header file containing the git commit hash. This means that when the commit changes, cmake reconfigures and the core lib is recompiled. With this change, the absence of a commit hash is explicitly handled with `std::optional`. At install time, we look up the commit hash and regenerate the header file into the install directory. If the source folder is not a repository (like when building from a tarball), the configure-time header is copied with the `nullopt` commit hash to indicate not commit is available.

The current implementation of the space point formation couples strongly to the existing space point templating which is replaced by the new EDM and `Seeding2`. Similarly this PR adds a new package `SpacePointFormation2`, which generalizes the functionality and decouples it from the EDM.

…ject#4682) Brings multiple abortes to the `KalmanFitter`: - end of world - volume constraint - path limit - target surface This should allow successfully fitting tracks without finding all the measurements or reaching the end of the detector, which was only detected by the navigator state right now. Small changes were performed on the CKF to align it with the KF code better.

Broken out of acts-project#4607

…ctor (acts-project#4699) - Add Tgc like chambers to the middle endcap wheel. Endcap construction still disabled because we run out of volume identifiers - Implement a small wheel structure

…cts-project#4700) - Introduce RootMuonSpacePointWriter & RootMuonSpacePointReader - Possibility to construct the MuonId from a single integer

… same time (acts-project#4638) This PR changes the navigator behavior for gen3 geometry configuration by updating the `NavigationStream` with `NavigationCandidates` that can be portals and surfaces and sorts them with the path length. For now, the way I did it is that in the methods that are used in the Propagation I just put a check if we are in gen3 case or not. Co-authored-by: Petr Balek <122273631+pbalek@users.noreply.github.com> Co-authored-by: Vakho Tsulaia <6815026+tsulaiav@users.noreply.github.com> Co-authored-by: Paul Gessinger <1058585+paulgessinger@users.noreply.github.com> Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com> Co-authored-by: Stephen Nicholas Swatman <1165820+stephenswat@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <245573+veprbl@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com> Co-authored-by: Andreas Salzburger <26623879+asalzburger@users.noreply.github.com> Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>

This commit makes the codegen respect the `ACTS_USE_SYSTEM_LIBS` flag, allowing users to build ACTS in a fully offline environment if they have the dependencies already installed. To make this possible, I added a code path which avoids uv and uses the (virtual) Python environment provided by the user. This is the second attempt at acts-project#4141.

This PR cleans up the `Tests` folder. * It uses consistently `using namespace XYZ` for the Acts libraries it depends on * It guards consistently the testing code with `namespace ActsTest { ... }` to access common testing code * It renames consistently the tests suites and introduces them where missing * it corrects the missing folder movement of `Acts/Plugins/Json` to `ActsPlugins/Json` with deprecated files to protect traccc temporarily --- END COMMIT MESSAGE --- Any further description goes here, @-mentions are ok here! - Use a *conventional commits* prefix: [quick summary](https://www.conventionalcommits.org/en/v1.0.0/#summary) - We mostly use `feat`, `fix`, `refactor`, `docs`, `chore` and `build` types. - A milestone will be assigned by one of the maintainers

Full log: https://github.com/acts-project/acts/actions/runs/18252888898

coderabbitai · 2026-03-06T14:14:47Z

Important

Review skipped

Too many files!

This PR contains 227 files, which is 77 over the limit of 150.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 53fdd59f-d49e-478a-b1a3-eec861756ad2

📥 Commits

Reviewing files that changed from the base of the PR and between d72f216 and f51a42c.

⛔ Files ignored due to path filters (73)

CI/physmon/reference/particles_fatras_hist.root is excluded by !**/*.root
CI/physmon/reference/particles_geant4_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_ambi_orthogonal.root is excluded by !**/*.root
CI/physmon/reference/performance_ambi_seeded.root is excluded by !**/*.root
CI/physmon/reference/performance_ambi_ttbar.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_gridseeder_seeded_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_orthogonal_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_seeded_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_truth_estimated_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_truth_smeared_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_amvf_ttbar_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_ckf_orthogonal.root is excluded by !**/*.root
CI/physmon/reference/performance_ckf_seeded.root is excluded by !**/*.root
CI/physmon/reference/performance_ckf_truth_estimated.root is excluded by !**/*.root
CI/physmon/reference/performance_ckf_truth_smeared.root is excluded by !**/*.root
CI/physmon/reference/performance_ckf_ttbar.root is excluded by !**/*.root
CI/physmon/reference/performance_gsf.root is excluded by !**/*.root
CI/physmon/reference/performance_gx2f.root is excluded by !**/*.root
CI/physmon/reference/performance_ivf_orthogonal_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_ivf_seeded_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_ivf_truth_estimated_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_ivf_truth_smeared_hist.root is excluded by !**/*.root
CI/physmon/reference/performance_seeding_orthogonal.root is excluded by !**/*.root
CI/physmon/reference/performance_seeding_seeded.root is excluded by !**/*.root
CI/physmon/reference/performance_seeding_truth_estimated.root is excluded by !**/*.root
CI/physmon/reference/performance_seeding_ttbar.root is excluded by !**/*.root
CI/physmon/reference/performance_truth_tracking.root is excluded by !**/*.root
CI/physmon/reference/simulation/particles_fatras_hist.root is excluded by !**/*.root
CI/physmon/reference/simulation/particles_geant4_hist.root is excluded by !**/*.root
CI/physmon/reference/simulation/particles_ttbar_hist.root is excluded by !**/*.root
CI/physmon/reference/simulation/vertices_ttbar_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/orthogonal/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/orthogonal/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/orthogonal/performance_seeding.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/orthogonal/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/seeded/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/seeded/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/seeded/performance_seeding.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/seeded/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_estimated/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_estimated/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_estimated/performance_seeding.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_estimated/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_smeared/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_smeared/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_1muon/truth_smeared/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_finding_ckf_ambi.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_seeding.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_vertexing_amvf_gauss_notime_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_vertexing_amvf_grid_time_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/performance_vertexing_ivf_notime_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_4muon_50vertices/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_finding_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_finding_ckf_ambi.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_finding_ckf_ml_solver.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_fitting_ckf.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_seeding.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_vertexing_amvf_gauss_notime_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/performance_vertexing_amvf_grid_time_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfinding_ttbar_pu200/tracksummary_ckf_hist.root is excluded by !**/*.root
CI/physmon/reference/trackfitting_gsf/performance_trackfitting.root is excluded by !**/*.root
CI/physmon/reference/trackfitting_gx2f/performance_trackfitting.root is excluded by !**/*.root
CI/physmon/reference/trackfitting_kf/performance_trackfitting.root is excluded by !**/*.root
CI/physmon/reference/trackrefitting_gsf/performance_trackrefitting.root is excluded by !**/*.root
CI/physmon/reference/trackrefitting_kf/performance_trackrefitting.root is excluded by !**/*.root
CI/physmon/reference/tracksummary_ckf_orthogonal_hist.root is excluded by !**/*.root
CI/physmon/reference/tracksummary_ckf_seeded_hist.root is excluded by !**/*.root
CI/physmon/reference/tracksummary_ckf_truth_estimated_hist.root is excluded by !**/*.root
CI/physmon/reference/tracksummary_ckf_truth_smeared_hist.root is excluded by !**/*.root
CI/physmon/reference/tracksummary_ckf_ttbar_hist.root is excluded by !**/*.root

📒 Files selected for processing (227)

.clang-format
.clang-tidy
.devcontainer/Dockerfile
.devcontainer/devcontainer.json
.devcontainer/setup.sh
.gersemirc
.github/actions/dependencies/action.yml
.github/dependabot.yml
.github/issue_template.md
.github/labeler.yml
.github/pull_request_template.md
.github/wip.yml
.github/workflows/analysis.yml
.github/workflows/backport.yml
.github/workflows/builds.yml
.github/workflows/checks.yml
.github/workflows/devcontainer-ci.yml
.github/workflows/docs.yml
.github/workflows/iwyu.yml
.github/workflows/labels.yml
.github/workflows/milestone.yml
.github/workflows/pr-lint.yml
.github/workflows/release.yml
.github/workflows/report.yml
.github/workflows/sonarcloud.yml
.github/workflows/stale.yml
.github/workflows/update-pip-requirements.yml
.gitignore
.gitlab-ci.yml
.kodiak.toml
.merge-sentinel.yml
.pre-commit-config.yaml
.zenodo.json
AUTHORS
Alignment/CMakeLists.txt
Alignment/README.md
Alignment/include/ActsAlignment/Kernel/Alignment.hpp
Alignment/include/ActsAlignment/Kernel/Alignment.ipp
Alignment/include/ActsAlignment/Kernel/AlignmentError.hpp
Alignment/include/ActsAlignment/Kernel/AlignmentMask.hpp
Alignment/include/ActsAlignment/Kernel/detail/AlignmentEngine.hpp
Alignment/src/Kernel/detail/AlignmentEngine.cpp
CI/README.md
CI/check_boost_test_macro.sh
CI/check_codegen_dependencies.sh
CI/check_format
CI/check_include_guards.py
CI/check_license.py
CI/check_math_macros.py
CI/check_pragma_once.sh
CI/check_size_t.py
CI/check_smearing_config.py
CI/check_type_t.py
CI/check_unused_files.py
CI/clang_tidy/limits.yml
CI/clang_tidy/requirements.txt
CI/cliff.toml
CI/codespell_ignore.txt
CI/ctest2junit.xsl
CI/dependencies/opengl.sh
CI/dependencies/parallel.sh
CI/dependencies/select_lockfile.py
CI/dependencies/setup.sh
CI/dependencies/setup_spack.sh
CI/fix_pragma.py
CI/format_json.py
CI/fpe_masks/requirements.in
CI/fpe_masks/requirements.txt
CI/get_next_milestone.py
CI/iwyu/README.md
CI/iwyu/filter.py
CI/iwyu/filter.yaml
CI/iwyu/mapping-boost.imp
CI/iwyu/mapping-eigen.imp
CI/iwyu/mapping-pythia.imp
CI/iwyu/mapping.imp
CI/missing_include_check.sh
CI/physmon/ckf_truth_smeared.yml
CI/physmon/config/default.yml
CI/physmon/config/info_only.yml
CI/physmon/config/pythia8_ttbar.yml
CI/physmon/config/simulation.yml
CI/physmon/config/trackfitting_gsf.yml
CI/physmon/config/trackfitting_gx2f.yml
CI/physmon/config/trackfitting_kf.yml
CI/physmon/config/tracksummary_ckf.yml
CI/physmon/config/vertexing_4muon_50vertices.yml
CI/physmon/config/vertexing_ttbar_pu200.yml
CI/physmon/default.yml
CI/physmon/phys_perf_mon.sh
CI/physmon/physmon_common.py
CI/physmon/reference/commit
CI/physmon/summary.py
CI/physmon/tracksummary_ckf_config.yml
CI/physmon/vertexing_config.yml
CI/physmon/vertexing_ttbar_config.yml
CI/physmon/workflows/physmon_ckf_tracking.py
CI/physmon/workflows/physmon_simulation.py
CI/physmon/workflows/physmon_track_finding_ttbar.py
CI/physmon/workflows/physmon_trackfinding_1muon.py
CI/physmon/workflows/physmon_trackfinding_4muon_50vertices.py
CI/physmon/workflows/physmon_trackfinding_ttbar_pu200.py
CI/physmon/workflows/physmon_trackfitting_gsf.py
CI/physmon/workflows/physmon_trackfitting_gx2f.py
CI/physmon/workflows/physmon_trackfitting_gx2f_vs_kf.py
CI/physmon/workflows/physmon_trackfitting_kf.py
CI/physmon/workflows/physmon_trackrefitting_gsf.py
CI/physmon/workflows/physmon_trackrefitting_kf.py
CI/physmon/workflows/physmon_truth_tracking_gsf.py
CI/physmon/workflows/physmon_truth_tracking_gx2f.py
CI/physmon/workflows/physmon_truth_tracking_kalman.py
CI/physmon/workflows/physmon_vertexing.py
CI/release.py
CI/release.sh
CI/release_requirements.in
CI/release_requirements.txt
CI/requirements.txt
CI/requirements_fpe_masks.txt
CI/setup_cvmfs_lcg.sh
CI/setup_cvmfs_lcg100.sh
CI/setup_cvmfs_lcg101.sh
CI/setup_cvmfs_lcg105.sh
CI/test_coverage.py
CITATION.cff
CMakeLists.txt
CMakePresets.json
CODE_OF_CONDUCT.md
CONTRIBUTING.rst
Core/ActsVersion.hpp.in
Core/CMakeLists.txt
Core/include/Acts/AmbiguityResolution/AmbiguityNetworkConcept.hpp
Core/include/Acts/AmbiguityResolution/AmbiguityResolutionML.hpp
Core/include/Acts/AmbiguityResolution/GreedyAmbiguityResolution.hpp
Core/include/Acts/AmbiguityResolution/GreedyAmbiguityResolution.ipp
Core/include/Acts/AmbiguityResolution/ScoreBasedAmbiguityResolution.hpp
Core/include/Acts/AmbiguityResolution/ScoreBasedAmbiguityResolution.ipp
Core/include/Acts/Clusterization/Clusterization.hpp
Core/include/Acts/Clusterization/Clusterization.ipp
Core/include/Acts/Clusterization/TimedClusterization.hpp
Core/include/Acts/Clusterization/TimedClusterization.ipp
Core/include/Acts/Definitions/Algebra.hpp
Core/include/Acts/Definitions/Alignment.hpp
Core/include/Acts/Definitions/Common.hpp
Core/include/Acts/Definitions/Direction.hpp
Core/include/Acts/Definitions/ParticleData.hpp
Core/include/Acts/Definitions/PdgParticle.hpp
Core/include/Acts/Definitions/Tolerance.hpp
Core/include/Acts/Definitions/TrackParametrization.hpp
Core/include/Acts/Definitions/Units.hpp
Core/include/Acts/Detector/Blueprint.hpp
Core/include/Acts/Detector/CuboidalContainerBuilder.hpp
Core/include/Acts/Detector/CylindricalContainerBuilder.hpp
Core/include/Acts/Detector/Detector.hpp
Core/include/Acts/Detector/DetectorBuilder.hpp
Core/include/Acts/Detector/DetectorComponents.hpp
Core/include/Acts/Detector/DetectorVolume.hpp
Core/include/Acts/Detector/DetectorVolumeBuilder.hpp
Core/include/Acts/Detector/DetectorVolumeVisitorConcept.hpp
Core/include/Acts/Detector/GeometryCompatibilityConcept.hpp
Core/include/Acts/Detector/GeometryIdGenerator.hpp
Core/include/Acts/Detector/GeometryIdMapper.hpp
Core/include/Acts/Detector/IndexedRootVolumeFinderBuilder.hpp
Core/include/Acts/Detector/KdtSurfacesProvider.hpp
Core/include/Acts/Detector/LayerStructureBuilder.hpp
Core/include/Acts/Detector/MultiWireStructureBuilder.hpp
Core/include/Acts/Detector/Portal.hpp
Core/include/Acts/Detector/PortalGenerators.hpp
Core/include/Acts/Detector/ProtoBinning.hpp
Core/include/Acts/Detector/ProtoDetector.hpp
Core/include/Acts/Detector/ProtoSupport.hpp
Core/include/Acts/Detector/VolumeStructureBuilder.hpp
Core/include/Acts/Detector/detail/BlueprintDrawer.hpp
Core/include/Acts/Detector/detail/BlueprintHelper.hpp
Core/include/Acts/Detector/detail/CuboidalDetectorHelper.hpp
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Core/include/Acts/Detector/detail/DetectorVolumeConsistency.hpp
Core/include/Acts/Detector/detail/IndexedGridFiller.hpp
Core/include/Acts/Detector/detail/IndexedSurfacesGenerator.hpp
Core/include/Acts/Detector/detail/PortalHelper.hpp
Core/include/Acts/Detector/detail/ProtoMaterialHelper.hpp
Core/include/Acts/Detector/detail/ReferenceGenerators.hpp
Core/include/Acts/Detector/detail/SupportSurfacesHelper.hpp
Core/include/Acts/Detector/interface/IDetectorBuilder.hpp
Core/include/Acts/Detector/interface/IDetectorComponentBuilder.hpp
Core/include/Acts/Detector/interface/IExternalStructureBuilder.hpp
Core/include/Acts/Detector/interface/IGeometryIdGenerator.hpp
Core/include/Acts/Detector/interface/IInternalStructureBuilder.hpp
Core/include/Acts/Detector/interface/IRootVolumeFinderBuilder.hpp
Core/include/Acts/Detector/interface/ISurfacesProvider.hpp
Core/include/Acts/Digitization/CartesianSegmentation.hpp
Core/include/Acts/Digitization/DigitizationCell.hpp
Core/include/Acts/Digitization/DigitizationModule.hpp
Core/include/Acts/Digitization/DigitizationSourceLink.hpp
Core/include/Acts/Digitization/PlanarModuleCluster.hpp
Core/include/Acts/Digitization/PlanarModuleStepper.hpp
Core/include/Acts/Digitization/Segmentation.hpp
Core/include/Acts/EventData/Charge.hpp
Core/include/Acts/EventData/ChargeConcept.hpp
Core/include/Acts/EventData/CompositeSpacePoint.hpp
Core/include/Acts/EventData/CompositeSpacePointCalibrator.hpp
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp
Core/include/Acts/EventData/GenericCurvilinearTrackParameters.hpp
Core/include/Acts/EventData/GenericFreeTrackParameters.hpp
Core/include/Acts/EventData/GenericParticleHypothesis.hpp
Core/include/Acts/EventData/Measurement.hpp
Core/include/Acts/EventData/MeasurementHelpers.hpp
Core/include/Acts/EventData/MultiComponentTrackParameters.hpp
Core/include/Acts/EventData/MultiTrajectory.hpp
Core/include/Acts/EventData/MultiTrajectory.ipp
Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp
Core/include/Acts/EventData/MultiTrajectoryHelpers.hpp
Core/include/Acts/EventData/ParticleHypothesis.hpp
Core/include/Acts/EventData/ProxyAccessor.hpp
Core/include/Acts/EventData/Seed.hpp
Core/include/Acts/EventData/Seed.ipp
Core/include/Acts/EventData/SeedContainer2.hpp
Core/include/Acts/EventData/SeedContainer2.ipp
Core/include/Acts/EventData/SeedProxy2.hpp
Core/include/Acts/EventData/SourceLink.hpp
Core/include/Acts/EventData/SpacePointColumnProxy2.hpp
Core/include/Acts/EventData/SpacePointContainer.hpp
Core/include/Acts/EventData/SpacePointContainer.ipp
Core/include/Acts/EventData/SpacePointContainer2.hpp
Core/include/Acts/EventData/SpacePointContainer2.ipp
Core/include/Acts/EventData/SpacePointData.hpp
Core/include/Acts/EventData/SpacePointData.ipp
Core/include/Acts/EventData/SpacePointMutableData.hpp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

benjaminhuth and others added 30 commits July 17, 2025 12:16

refactor(gen3): Material designator node takes arbitrary surface mate…

e9bd007

…rial (acts-project#4441)

refactor: Shuffle if statement in DoubletSeedFinder (acts-project…

9645a10

…#4446) Avoids code duplication. This is also how the original seeding code looks like which makes it easier to compare.

ci: Add LCG107a and LCG108 jobs (acts-project#4438)

5ba27d5

build: VecMem Setup Fix (acts-project#4451)

62572cb

Find vecmem before setting up the libraries that need it. So that a pre-built vecmem installation could be used together with algebra-plugins and detray being built by this project.

feat: introduce alignment decorator for Examples (acts-project#4377)

b5d2f76

This is the cherry-picked version of acts-project#4315 and introduces a common alignment decorator that can be used with different detectors in the Examples framework.

feat: TrackingVolume gets access method to nav policy (acts-project#4444

b858646

)

chore: Bump detray to 0.101.0 (acts-project#4449)

a4feead

Merge branch 'main' into releases

0bdb83c

Bump version to v42.1.0

dd18c64

test: Add a temporary directory helper (acts-project#4454)

b1ca56a

This helper can be instantiated from a unit test. It will look up the test name and create a temporary directory that can be used during the test.

ci: Fetch spack repo before checkout (acts-project#4460)

c692873

Fix missing tag by explicitly fetching. I have a more correct fix in the pipeline.

chore: Lockfile selection script also retries on URLError (acts-proje…

aed5dcd

…ct#4458) The retry logic currently only works for HTTPError. I'm observing URLError in CI now, so I'm including this exception in the retry logic as well now.

build: Point gersemi (cmake formatter) at definitions (acts-project#4459

f3f54fd

) This allows it to take better formatting decisions for custom functions.

feat: CompositePortalLink exposes child links (acts-project#4443)

db9ae6e

- SVG drawing uses it to draw composites as well - Add a comment to indicate that the composite conversion in some cases (edge) does not produce a grid portal

ci: Reduce LCG coverage, keep representative set of version (acts-pro…

f0db82a

…ject#4457) The goal is to cover as many compilers as possible, so now we test on clang16, gcc13, gcc14, gcc15 and clang19 across LCG 106a, 107, 107a and 108

docs: Surface::center returns a value (acts-project#4462)

b45cc70

refactor: Make SurfaceArray::getBinCenter const (acts-project#4461)

c175d93

This function does not mutate the state of the `SurfaceArray` and therefore marked as `const`

ci: hotfix for eic-shell failures (acts-project#4468)

52ca015

Since recent container upgrade we are seeing build failures. This allows to bypass the erroneous process until we figure out a proper fix.

ci: Second attempt at an std::format check (acts-project#4423)

035151e

The previous attempt failed, because I did not explicitly ask the check to include the C++20 compiler flag, which failed in some conditions.

feat: ProxyAccessor gets function to check existence (acts-project#4433)

42aa69a

Also adds some tests to ensure ProxyAccessor can be constexpr created.

fix: Handle phi grid correctly in SurfaceArrayCreator (acts-project…

611447a

…#4466) - Fix phi binning so grid positions align with surface positions - `disk` -> `disc`

ci: Use Spack 1.0, lock builtin repo, update payload (acts-project#4465)

643e361

andiwand and others added 29 commits October 2, 2025 15:04

feat: Add env variable pointing to acts main folder in the setup (act…

2b9e53a

…s-project#4691) I've added an environment variable `ACTS_SOURCE_DIR` to the `this_acts.sh` script for harmonize the setup scripts

docs: Fix doxygen warnings in FATRAS (acts-project#4689)

8616f4d

Broken out of acts-project#4607

feat: enable reading of detray detector from files (acts-project#4695)

cc4f251

This PR enables the reading of the detray detector from json files.

docs: Fix doxygen warnings in the DD4hep plugin (acts-project#4687)

b4c7fce

Broken out of acts-project#4607

docs: Fix doxygen warning in ONNX plugin (acts-project#4685)

157517b

Broken out of acts-project#4607

docs: Fix doxygen warnings in the GNN plugin (acts-project#4688)

0935c85

Broken out of acts-project#4607

docs: Fix doxygen warnings in the ROOT plugin (acts-project#4684)

30c9cca

Broken out of acts-project#4607

feat: ActsExample - Complete the endcap wheel in the mockup muon dete…

99b8619

…ctor (acts-project#4699) - Add Tgc like chambers to the middle endcap wheel. Endcap construction still disabled because we run out of volume identifiers - Implement a small wheel structure

feat: ActsExamples - Dump & Read MuonSpacePoints to/from ROOT files (a…

e77421b

…cts-project#4700) - Introduce RootMuonSpacePointWriter & RootMuonSpacePointReader - Possibility to construct the MuonId from a single integer

ci: Add pre-commit hook for json formatting (acts-project#4701)

e0c49a0

chore: automated python requirements upgrades (acts-project#4696)

97950d4

Full log: https://github.com/acts-project/acts/actions/runs/18252888898

Merge remote-tracking branch 'upstream/main' into releases

55ffd43

Bump version to v44.0.0

d5d65c7

merge v40.0.0

3e0a3dc

not sure what happened with this file

3d02e2e

merge with v44.0.0

b8463e4

add install headers for files needed by tgeo

94a72be

add a wrapper function for the geometry building

f51a42c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update to Actsv44#44

feat: update to Actsv44#44
osbornjd wants to merge 1359 commits intosPHENIX-Collaboration:sPHENIXfrom
osbornjd:sPHENIXv44

osbornjd commented Mar 6, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 6, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

osbornjd commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 6, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

osbornjd commented Mar 6, 2026 •

edited

Loading