Skip to content

47287 was the first run2pp physics run passing our 5minute cut#4264

Merged
pinkenburg merged 1 commit into
sPHENIX-Collaboration:masterfrom
pinkenburg:first-run2pp
May 9, 2026
Merged

47287 was the first run2pp physics run passing our 5minute cut#4264
pinkenburg merged 1 commit into
sPHENIX-Collaboration:masterfrom
pinkenburg:first-run2pp

Conversation

@pinkenburg
Copy link
Copy Markdown
Contributor

@pinkenburg pinkenburg commented May 8, 2026

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR changes the first run2pp physics run from 47286 to 47287. Run 47286 is just 30 seconds long and is therefore not among the reconstructed run2pp runs

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Motivation / Context

Run 47286 was initially identified as the first Run 2 proton-proton physics run but was only 30 seconds in duration, failing to meet the established reconstruction criteria for Run 2 datasets. sPHENIX requires Run 2 proton-proton physics runs to satisfy a minimum 5-minute duration threshold and accumulate at least 100k events. Run 47287 is the first run that meets these quality standards.

Key Changes

  • Updated RUN2PP_FIRST constant in RunnumberRange.h from 47286 to 47287
  • This adjusts the run-number boundary definition for identifying Run 2 proton-proton physics data in downstream reconstruction and analysis code
  • File: offline/framework/phool/RunnumberRange.h (+2/-2 lines)

Potential Risk Areas

  • Reconstruction behavior: Any code that filters or selects Run 2 proton-proton data using RUN2PP_FIRST will now exclude run 47286, potentially affecting:
    • Existing datasets indexed by run number ranges
    • Analysis workflows that explicitly include early runs in this period
    • Calibration procedures tied to specific run ranges
  • Data consistency: Validation of run-selection logic across the collaboration's analysis framework should ensure consistency with this new boundary

Possible Future Improvements

  • Document run 47286's exclusion in data quality notes to ensure analysis teams are aware of the gap
  • Consider automated validation checks in reconstruction that verify runs meet the stated quality criteria (≥5 minutes, ≥100k events)

Note: This summary is AI-generated and should be cross-checked against the actual code changes. Use your best judgment when reviewing critical data selection logic.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e21f2a69-07d0-4731-84c7-678922a679fc

📥 Commits

Reviewing files that changed from the base of the PR and between e7a8cb6 and 91da544.

📒 Files selected for processing (1)
  • offline/framework/phool/RunnumberRange.h

📝 Walkthrough

Walkthrough

The PR updates the RUN2PP_FIRST constant in RunnumberRange.h from 47286 to 47287, adjusting the inclusive first-run boundary for the RUN2PP data-taking period.

Changes

RUN2PP Run Number Boundary

Layer / File(s) Summary
Run Number Constant Update
offline/framework/phool/RunnumberRange.h
RUN2PP_FIRST constant is incremented from 47286 to 47287 to update the run-number boundary.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sphenix-jenkins-ci
Copy link
Copy Markdown

Build & test report

Report for commit 91da54406caacad9b07ac43f68b4bc4d3142ffa4:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@pinkenburg pinkenburg merged commit 988dbf9 into sPHENIX-Collaboration:master May 9, 2026
22 checks passed
@pinkenburg pinkenburg deleted the first-run2pp branch May 9, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant