47287 was the first run2pp physics run passing our 5minute cut#4264
Merged
Conversation
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the ChangesRUN2PP Run Number Boundary
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Build & test reportReport for commit 91da54406caacad9b07ac43f68b4bc4d3142ffa4:
Automatically generated by sPHENIX Jenkins continuous integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
This PR changes the first run2pp physics run from 47286 to 47287. Run 47286 is just 30 seconds long and is therefore not among the reconstructed run2pp runs
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Motivation / Context
Run 47286 was initially identified as the first Run 2 proton-proton physics run but was only 30 seconds in duration, failing to meet the established reconstruction criteria for Run 2 datasets. sPHENIX requires Run 2 proton-proton physics runs to satisfy a minimum 5-minute duration threshold and accumulate at least 100k events. Run 47287 is the first run that meets these quality standards.
Key Changes
RUN2PP_FIRSTconstant inRunnumberRange.hfrom47286to47287offline/framework/phool/RunnumberRange.h(+2/-2 lines)Potential Risk Areas
RUN2PP_FIRSTwill now exclude run 47286, potentially affecting:Possible Future Improvements
Note: This summary is AI-generated and should be cross-checked against the actual code changes. Use your best judgment when reviewing critical data selection logic.