Design for new Create Shopify Order service#151
Draft
gurveenbagga wants to merge 1 commit intomainfrom
Draft
Conversation
dt2patel
reviewed
Dec 24, 2025
| **Purpose:** Prevent duplicate order creation. | ||
| **Logic:** | ||
|
|
||
| - Check `OrderIdentification` for `SHOPIFY_ORD_ID = legacyResourceId`. |
Contributor
There was a problem hiding this comment.
I don't personally like that we have to check a vertical table rather than just checking external id. why not just Shopify shop order table?
|
|
||
| ## 3. Tags | ||
|
|
||
| **Purpose:** Skip order import if tags match forbidden tags. |
Contributor
There was a problem hiding this comment.
why not just filter these in your graphql bulk query?
|
|
||
| #### Mixed Cart POS Order: | ||
| - Shipping address exists | ||
| - AND `displayFulfillmentStatus = PARTIALLY_FULFILLED` |
Contributor
There was a problem hiding this comment.
why do we need to check fulfillment status when assigning channel?
|
|
||
| ## 7. Default Facility & Location Facility | ||
|
|
||
| ** Default Facility:** |
Contributor
There was a problem hiding this comment.
facility id should simply be whatever facility is set on the order in shopify and the location that it maps to in hotwax using the Shopify shop mapping table. no need to check default inventory facility
Comment on lines
+139
to
+143
| If `staffMember.id` exists: | ||
|
|
||
| Add attribute: | ||
|
|
||
| - `attrName = shopify_user_id` |
Contributor
There was a problem hiding this comment.
is there a way to use order role here instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.