Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear networkcommoners,
I am submitting this new pull request to address the feedback provided in PR #62.
As suggested by @deeenes (btw thanks a lot for the refactoring), I have created a dedicated vignette for SignalingProfiler, with two illustrative use cases:
During testing, I encountered an issue with the refactored
mf_classifierfunction in SignalingProfiler, which wasn't correctly importing the table on my side. Hence, I wasn't really able to check the vignette results.I hope that the two use cases in the SignalingProfiler vignette can serve as useful unit tests.
Additionally, this PR includes:
Thank you all for the feedback and ongoing support.
Please don’t hesitate to reach out if you have any questions or suggestions.
Cheers,
Veronica and PerfettoLab