fix: use palette icon for session-row and server-tile color pickers#288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #287, which replaced the color-picker's
U+25A0"stop square" with a palette icon on window rows. The same■glyph was still used by two other color triggers, so they read as stop buttons too. This propagates the palette icon to them and shares a single icon component.server-panel.tsx) — the server blocks in the server pane (the explicitly-requested spot). Rendered atsize={12}to fit the compact tile's action cluster.session-row.tsx) — included for consistency, so no stop-square color trigger remains anywhere in the sidebar. (Happy to drop this if you only wanted the server pane.)PaletteIcon(previously local towindow-row.tsx) into the sharedsidebar/icons.tsx, with an optionalsizeprop (default 13). Window-row now imports it instead of defining its own copy — no behavior change there.sidebar/icons.ts(theICON_CLASSconstant used by host-panel/status-panel) intoicons.tsx, removing the.ts. Twoicons.*files in one directory is a resolution footgun — TS resolves./iconsto the.tsand silently ignores the.tsx. Importers of./iconsare unaffected.All triggers keep their existing
aria-label("Set color for …") and hover/coarse:/focus-visible:reveal behavior — purely a visual swap.Verified:
just check(tsc) clean; full frontend unit suite 794/794 pass (includes window-row, session-row, server-panel, host-panel, status-panel). Frontend-only, presentational — no Go or API surface touched.