Skip to content

Update golang sdk version to fix issues within commands coming from t… #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyler-mairose-sp merged 2 commits into from
Jun 1, 2026
Merged

Update golang sdk version to fix issues within commands coming from t… #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f6db6
Update golang sdk version to fix issues within commands coming from t…
tyler-mairose-sp Jun 1, 2026
10fa206
Fix connector tests
tyler-mairose-sp Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/connector/static/connector/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { connector } from './index'
import { Connector, RawResponse, ResponseType, StandardCommand, AssumeAwsRoleRequest, AssumeAwsRoleResponse } from '@sailpoint/connector-sdk'
import { Connector, RawResponse, ResponseType, StandardCommand, AssumeAwsRoleRequest, AssumeAwsRoleResponse, OAuth2AccessTokenRequest, OAuth2AccessTokenResponse } from '@sailpoint/connector-sdk'
import { PassThrough } from 'stream'

const mockConfig: any = {
Expand All @@ -21,6 +21,9 @@ describe('connector unit tests', () => {
},
assumeAwsRole(assumeAwsRoleRequest: AssumeAwsRoleRequest): Promise<AssumeAwsRoleResponse> {
return Promise.resolve(new AssumeAwsRoleResponse('accessKeyId', 'secretAccessKey', 'sessionToken', "123"))
},
getOAuth2AccessToken(request: OAuth2AccessTokenRequest): Promise<OAuth2AccessTokenResponse> {
return Promise.resolve({})
}
},
undefined,
Expand Down
8 changes: 7 additions & 1 deletion cmd/connector/static/customizer/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { connectorCustomizer } from './index'
import { CustomizerType, StandardCommand, AssumeAwsRoleRequest, AssumeAwsRoleResponse } from '@sailpoint/connector-sdk'
import { CustomizerType, StandardCommand, AssumeAwsRoleRequest, AssumeAwsRoleResponse, OAuth2AccessTokenRequest, OAuth2AccessTokenResponse } from '@sailpoint/connector-sdk'

const mockConfig: any = {
token: 'xxx123',
Expand All @@ -23,6 +23,9 @@ describe('connector customizer unit tests', () => {
new AssumeAwsRoleResponse('ccessKeyId', 'secretAccessKey', 'sessionToken', '123')
)
},
getOAuth2AccessToken(request: OAuth2AccessTokenRequest): Promise<OAuth2AccessTokenResponse> {
return Promise.resolve({})
},
},
input
)
Expand All @@ -43,6 +46,9 @@ describe('connector customizer unit tests', () => {
new AssumeAwsRoleResponse('ccessKeyId', 'secretAccessKey', 'sessionToken', '123')
)
},
getOAuth2AccessToken(request: OAuth2AccessTokenRequest): Promise<OAuth2AccessTokenResponse> {
return Promise.resolve({})
},
},
{
identity: '',
Expand Down
2 changes: 1 addition & 1 deletion cmd/reassign/reassign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ func determineObjectTypeAndCreateReassignment(objectId string, from string, to s
}
} else {
if resp.StatusCode == http.StatusOK {
if source.Owner.Id != nil && *source.Owner.Id != from {
if source.Owner.Get().Id != nil && *source.Owner.Get().Id != from {
return summary, errors.New("the source is not owned by the specified identity")
}

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ require (
github.com/mrz1836/go-sanitize v1.5.2
github.com/olekukonko/tablewriter v1.0.9
github.com/pkg/sftp v1.13.9
github.com/sailpoint-oss/golang-sdk/v2 v2.4.0
github.com/sailpoint-oss/golang-sdk/v2 v2.7.88
github.com/sailpoint-oss/jsonslice v0.0.0-20241219164002-1091467abd7d
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.9.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ github.com/sahilm/fuzzy v0.1.1 h1:ceu5RHF8DGgoi+/dR5PsECjCDH1BE3Fnmpo7aVXOdRA=
github.com/sahilm/fuzzy v0.1.1/go.mod h1:VFvziUEIMCrT6A6tw2RFIXPXXmzXbOsSHF0DOI8ZK9Y=
github.com/sailpoint-oss/golang-sdk/v2 v2.4.0 h1:AB2DsdVLeJcJQoGjq2NJ3z5XGnF62kh/OGs4C3qujXs=
github.com/sailpoint-oss/golang-sdk/v2 v2.4.0/go.mod h1:uT9zApQzJuPlr8GOdTLYnRfpfYJoLWYntz5tjFxMAWY=
github.com/sailpoint-oss/golang-sdk/v2 v2.7.88 h1:cfmSixjPiFD1ecAVER2VWy6oVFGhXMpbGRCOY0tqW24=
github.com/sailpoint-oss/golang-sdk/v2 v2.7.88/go.mod h1:uT9zApQzJuPlr8GOdTLYnRfpfYJoLWYntz5tjFxMAWY=
github.com/sailpoint-oss/jsonslice v0.0.0-20241219164002-1091467abd7d h1:FDHRMuBPRUNAg1KTf0OIisZ1JahumbrTCkglffFW7uA=
github.com/sailpoint-oss/jsonslice v0.0.0-20241219164002-1091467abd7d/go.mod h1:X+NsRTl+el6obauuEmB61tmWpFuTjR+gAuMJMtDhZm8=
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966 h1:JIAuq3EEf9cgbU6AtGPK4CTG3Zf6CKMNqf0MHTggAUA=
Expand Down
Loading