Skip to content

WIP Strapi V5 Support#1

Closed
choilive wants to merge 1 commit intosaint-james-fr:masterfrom
choilive:strapi_v5
Closed

WIP Strapi V5 Support#1
choilive wants to merge 1 commit intosaint-james-fr:masterfrom
choilive:strapi_v5

Conversation

@choilive
Copy link

@choilive choilive commented Nov 5, 2024

WIP - Need to update tests

@saint-james-fr
Copy link
Owner

Hey thanks for the PR, let me know when its ready for full review.

@anthonyamar
Copy link

Any chance to merge this one and package a new version? The gem isn't working anymore since Strapi V5, without cloning and bundling it from local.
Tested the code without .attributes and it works.

Without this, we get:

articles = StrapiRuby.get(resource: :articles)
/Users/anthonyamar/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/irb-1.15.1/lib/irb.rb:406:in `full_message': undefined method `each_pair' for nil (NoMethodError)

      struct.each_pair do |key, value|
            ^^^^^^^^^^

Thanks!

@choilive
Copy link
Author

choilive commented Mar 4, 2025

I forgot about this PR 😅. I'll fix up the tests and this should be ready.

@anthonyamar
Copy link

@choilive, no worries, that's already super cool from you to have made the PR! Thanks

@saint-james-fr
Copy link
Owner

hey, great to seem some traction on this, let's fix this, feel free to update tests if that's not too much, submit it and i'll release it as a new major version quickly afterwards.

By the way, it's been a while i did not check the repo or the project as I'm not doing that much ruby right now but i'ld happily review PRs if you need anything from the V5 api or update the doc. Good to be back in the ruby game i guess!

@saint-james-fr
Copy link
Owner

saint-james-fr commented Apr 9, 2025

Hey everyone, i've finally took the time to complete the migration, fix test, find some bugs along the way and have some fun in the end. I'll merge the PR tomorrow night and release a new (breaking) major version 1.0.0 at the same time.
I've put everything in another PR so i'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants