Conversation
- Plan all changes (install, enable/disable, conflict resolve, unlisted disable) before showing them together, then ask for confirmation once - Skip confirmation entirely when there is nothing to change - Extract plan_existing_mod_changes, plan_expansion_mod_changes, and apply_single_change helpers to reduce nesting and block length
When a MOD has no version in mod-list.json (nil), treat it as no change rather than a version mismatch — version is optional in mod-list.json and absence means "use whatever is installed".
sakuro
deleted the
feature/mod-sync-show-combined-plan-and-confirm-once-before-applying-changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show a combined plan of all pending changes before asking for confirmation once, rather than asking separately for installs and silently applying other changes.
Changes
plan_existing_mod_changes,plan_expansion_mod_changes, andapply_single_changehelpers to reduce block nesting and length