Skip to content

🐛 Fix mod sync saving files when nothing changed#79

Merged
sakuro merged 1 commit intomainfrom
fix/nothing-to-change-message-but-mod-list-json-and-mod-settings-dat-are-still-saved
Mar 3, 2026
Merged

🐛 Fix mod sync saving files when nothing changed#79
sakuro merged 1 commit intomainfrom
fix/nothing-to-change-message-but-mod-list-json-and-mod-settings-dat-are-still-saved

Conversation

@sakuro
Copy link
Copy Markdown
Owner

@sakuro sakuro commented Mar 3, 2026

Summary

Fix mod sync incorrectly saving mod-list.json and mod-settings.dat even when nothing changed, causing misleading output like "Nothing to change" followed by "Updated mod-list.json".

Changes

  • Skip saving mod-list.json when no MOD list changes are needed
  • Skip saving mod-settings.dat when startup settings are unchanged
  • Detect actual startup settings changes by comparing save file settings against current mod-settings.dat
  • Include startup settings changes in the combined plan and confirmation flow

Before

ℹ Nothing to change
✓ Updated mod-list.json
✓ Updated mod-settings.dat
✓ Sync completed successfully

After

ℹ Nothing to change

Closes #74

- Skip saving mod-list.json when no MOD list changes are needed
- Skip saving mod-settings.dat when startup settings are unchanged
- Include startup settings changes in the plan and confirmation flow
- Closes #74
@sakuro sakuro merged commit 3af967c into main Mar 3, 2026
5 checks passed
@sakuro sakuro deleted the fix/nothing-to-change-message-but-mod-list-json-and-mod-settings-dat-are-still-saved branch March 3, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 "Nothing to change" message but mod-list.json and mod-settings.dat are still saved

1 participant