feat: use the right LWC/Dev server version for the org #596
Conversation
|
@abdulsattar I setup a quick call for us to review this PR today - I just want to ensure things are working as expected. Let me know if that time works |
abdulsattar
left a comment
abdulsattar
left a comment
There was a problem hiding this comment.
Nick and Brian review.
| "dependencies": { | ||
| "@lwc/lwc-dev-server": "~13.2.x", | ||
| "@lwc/sfdc-lwc-compiler": "~13.2.x", | ||
| "lwc": "~8.23.x" |
There was a problem hiding this comment.
Do we need 'lwc'?
There was a problem hiding this comment.
Check the bundle size.
|
|
||
| # flags.version-channel.summary | ||
|
|
||
| Manually specify which version channel to use (latest, prerelease, or next). |
There was a problem hiding this comment.
Nick: SFDX already has the api version command. Use that instead of version-channel.
There was a problem hiding this comment.
Verify how @lwc/compiler in peerDependencies in lwc-dev-server work.
There was a problem hiding this comment.
Nick: Create a new package that imports lwc-dev-server and @lwc/compiler to fix the peerDependencies.
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| # Run the custom version check script |
There was a problem hiding this comment.
We need a test to prevent dependabot from updating dependencies beyond the approved range of each version.
There was a problem hiding this comment.
Verify if dependabot acutaly updates aliases.
There was a problem hiding this comment.
Document api versioning with wlc-dev-server. if (version === "262") { }
There was a problem hiding this comment.
The CLI updates to the latest plugin always. Change teh frequency if it's too often and the bundle size too big.
There was a problem hiding this comment.
Nick: reduce the bundle size instead.
| // | ||
| // Your org is on API version 63.0, but this version of the CLI plugin supports API version 62.0. To use the plugin with this org, you can reinstall or update the plugin using the "latest" tag. For example: "sf plugins install @salesforce/plugin-lightning-dev@latest". | ||
| // Priority 3: Skip check for testing (legacy compatibility) | ||
| if (process.env.SKIP_API_VERSION_CHECK === 'true') { |
What does this PR do?
Implements Phase 1 of https://github.com/salesforcecli/plugin-lightning-dev/blob/nkruk/single-install-design/DUAL_VERSION_DESIGN.md
What issues does this PR fix or reference?
W-20405334