fix setting unix socket authentication on mariadb >= 10.4#62169
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Ch3LL
left a comment
There was a problem hiding this comment.
This will require a changelog and test coverage. We do have tests for version 10.4 so we would have caught this if the correct test was added. A good place to add the test is here: tests/pytests/integration/modules/test_mysql.py
|
@Vringe would you be able to loop back to this PR to add changelog and test coverage? |
|
@Ch3LL Unfortunately, I do not have the time at the moment. I tried to setup the dev environment a while ago to write and run the test but I could not get it to run properly. |
|
@garethgreenaway @pprkut Hey guys :) i saw you both did some other work for MariaDB 10.5+ support in other issues / pr's. Any chance you can help this pr out? |
|
@cebe I saw you did some MariaDB related work for salt 3006. Unfortunately this issue still persists. Could you maybe help me out with this? |
b824f2a to
e455210
Compare
twangboy
left a comment
There was a problem hiding this comment.
Please create a changelog and a test for this
Adds the missing changelog fragment and a unit test pinning the new MariaDB >= 10.4 ``ALTER USER ... IDENTIFIED VIA unix_socket`` code path in ``_mariadb_user_chpass``. The test also verifies the legacy ``UPDATE mysql.user`` path is still used on MariaDB < 10.4.
What does this PR do?
Quote from the MariaDB Docs:
Example state to reproduce (A user must already exist with an other authentication plugin than unix socket):
Previous Behavior
Salt still uses
UPDATE mysql.userwhen changing a users authentication plugin to unix_socket. This leads to a corrupted View:New Behavior
User is altered correctly on older and newer MariaDB versions.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No