Skip to content

[3006.x] fix #66686: don't fail for InvalidVersion, instead drop the version as-if it was never there #66687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Legrems wants to merge 1 commit into
base: 3006.x
Choose a base branch
from
Open

[3006.x] fix #66686: don't fail for InvalidVersion, instead drop the version as-if it was never there #66687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions salt/modules/pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,11 +1696,18 @@ def list_all_versions(
for line in result["stdout"].splitlines():
match = regex.search(line)
if match:
versions = [
v for v in match.group(1).split(", ") if v and excludes.match(v)
]
versions.sort(key=pkg_resources.parse_version)
break
versions = []
for v in match.group(1).split(", "):
if v and excludes.match(v):
try:
pkg_resources.parse_version(v)

except pkg_resources.extern.packaging.version.InvalidVersion as e:
logger.info(f"{e} for package {pkg}, skipping this version...")
continue

versions.append(v)

if not versions:
return None

Expand Down