runners/jobs: don't iterate non-iterable Target values in list_jobs

[SAY-5]

What does this PR do?

Hardens salt.runners.jobs.list_jobs against non-iterable Target values in the job cache.

list_jobs's search_target filter reads Target for each cached job, wraps strings in a list, then iterates:

targets = ret[item]["Target"]
if isinstance(targets, str):
    targets = [targets]
for target in targets:
    ...

If Target is neither a string nor an iterable — which happens for failed or aborted jobs (#68780) — for target in targets: raises TypeError and kills the whole query, not just the one bad entry.

This PR adds a small elif not isinstance(targets, (list, tuple, set)): targets = [] guard so a malformed Target is treated the same way a missing Target key already is: no target to match, skip and move on. String/list/tuple/set behaviour is unchanged.

What issues does this PR fix or reference?

Fixes #68780

Previous Behavior

Calling jobs.list_jobs search_target=... against a job cache that contains any entry with a non-iterable Target (e.g. Target: None from a failed job) raises:

TypeError: argument of type 'NoneType' is not iterable

and list_jobs returns no result at all.

New Behavior

Entries with a non-iterable Target are silently skipped from search_target matching; the rest of the query returns as expected. String/list/tuple/set targets keep working exactly as before.

Merge requirements satisfied?

• Changelog: changelog/68780.fixed.md
• Tests — the matching code path is inside a large list_jobs loop; happy to add a targeted unit test that seeds the cache with Target: None and asserts list_jobs returns rather than raises, if the maintainers prefer before merge.

Commits signed with GPG?

DCO-signed off (Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>).

[bdrx312]

Can just check if the type is Iterable instead of trying to enumerate possible iterable types.

from collections.abc import Iterable

isinstance(obj, Iterable)

I suggest not silently masking errors though and instead log a warning or at least a debug/trace message.

[SAY-5]

Thanks @bdrx312 — applied both suggestions:

1. Iterable check: replaced the explicit (list, tuple, set) instance check with isinstance(targets, collections.abc.Iterable), so any future iterable container the cache may grow (deque, generator, custom class) just works without re-listing every type. Strings are still pulled out beforehand so a single target string keeps getting wrapped in a list rather than being treated as a sequence of characters.
2. Non-silent skip: when a non-iterable Target is hit, log it at DEBUG with the offending job id, so operators have a breadcrumb back to the malformed cache row instead of having it disappear.

Verified locally on macOS, Python 3.13:

• black --check and isort --check: clean
• pytest tests/pytests/unit/runners/test_jobs.py -v: both tests pass
• Reverted salt/runners/jobs.py to master and re-ran the new test to confirm it fails with AssertionError: assert '20260421000000000002' in '' — i.e. the assertion pins the new debug-log behaviour as a regression test

Net diff: jobs.py +5 / -2; new test test_list_jobs_with_non_iterable_target covers both the no-crash and the debug-log paths.

[bdrx312]

Also there is another PR also attempting to fix this #68862

[SAY-5]

Closing in favor of #68862 — thanks @bdrx312.

[bdrx312]

Closing in favor of #68862 — thanks @bdrx312.

The author of that PR seems to be non-responsive and your solution is better than the current form in the other PR.