Skip to content

Fix NotADirectoryError in tools/pkg/build.py salt_onedir #69462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwoz wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −0
Open

Fix NotADirectoryError in tools/pkg/build.py salt_onedir #69462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f718c4
Fix NotADirectoryError in tools/pkg/build.py salt_onedir
dwoz Jun 17, 2026
c7aede9
Fix file.managed error prefix and redact basic-auth in source_hash er…
dwoz Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/69402.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Prefix ``file.managed`` error comments with ``Unable to manage file:`` and
redact HTTP basic-auth credentials from ``Source hash`` error messages in
``salt.modules.file.get_source_sum`` so they are not leaked in state output
or logs.
4 changes: 4 additions & 0 deletions changelog/69461.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix ``NotADirectoryError`` in ``tools/pkg/build.py`` ``salt_onedir`` by no
longer passing the source tarball path as the ``cwd=`` of the
``git add -f salt/_version.txt`` subprocess; the command now runs in the
salt source checkout (a real git working tree) as intended.
Loading