[3007.x] Remove linode-python dependency to silence install SyntaxWarnings (#69455)#69463
Open
dwoz wants to merge 1 commit into
Open
[3007.x] Remove linode-python dependency to silence install SyntaxWarnings (#69455)#69463dwoz wants to merge 1 commit into
dwoz wants to merge 1 commit into
Conversation
…ltstack#69455) The unmaintained `linode-python` 1.1.1 package targets the retired Linode API v3 and uses `is not 0` / `is 1` against literals, which Python 3.12+ emits as `SyntaxWarning` from `linode/api.py` lines 293, 348, and 356. On RHEL/Rocky/Oracle Linux 9.x, the salt-common onedir's post-install scriptlet imports the onedir's Python which in turn imports `linode-python` and the warnings surface during every package install/upgrade. Drop `linode-python` from `requirements/static/pkg/linux.txt` and its dependent CI/pkg linux lockfiles so it is no longer installed into the salt-common onedir. `salt.cloud.clouds.linode` already uses the Linode APIv4 over HTTP/JSON (no `linode-python` import), so the package is purely vestigial. This backports saltstack#69339 (3006.x) and mirrors saltstack#68871 (master/3008.x) to 3007.x. Fixes saltstack#69455
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backports #69339 (3006.x) to 3007.x. Removes the unmaintained
linode-python1.1.1 dependency fromrequirements/static/pkg/linux.txt(and dependent CI/pkg linux lockfiles) so the salt-common onedir install
stops emitting
SyntaxWarningfromlinode/api.pyon every RPM/DEBinstall/upgrade.
What issues does this PR fix or reference?
Fixes #69455
#69455 is the same symptom as #68992 (which #69339 fixes on 3006.x). The
underlying
linode-pythonpackage is also vendored on 3007.x, so thefix needs to be backported here.
Previous Behavior
apt-get install salt-common=3007.xand the equivalent RPM scriptleton RHEL/Rocky/Oracle Linux 9.x print:
New Behavior
linode-pythonis no longer installed into the onedir, so the warningsdon't surface.
salt.cloud.clouds.linodealready uses Linode APIv4 overHTTP/JSON (verified by
grep linode salt/cloud/clouds/linode.py) — itnever imported
linode-python, so dropping it is purely vestigialcleanup. Mirrors PR #68871 on master and PR #69339 on 3006.x.
Merge requirements satisfied?
changelog/69455.removed.mdsame as Clean up linode-python packages for retired Linode API v3 #68871 and Remove linode-python dependency to silence install SyntaxWarnings (#68992) #69339 which also did not add tests
Commits signed with GPG?
No (matching adjacent 3007.x commits, none of which are signed)