fix(common): correct formatTokenAmount for integer amounts + add util tests#34
Open
saltxd wants to merge 2 commits into
Open
fix(common): correct formatTokenAmount for integer amounts + add util tests#34saltxd wants to merge 2 commits into
saltxd wants to merge 2 commits into
Conversation
formatTokenAmount ran .replace(/\.?0+$/, '') unconditionally, so for 0-decimal
tokens toFixed(0) produced an integer string ('100') and the strip ate real
trailing zeros ('100' -> '1', '1200' -> '12'). Only strip when a decimal point
is present.
formatTokenAmount is exported from @chainward/common but currently has zero call
sites, so this fixes a latent display bug before first use.
Adds unit tests for previously-untested pure utilities in @chainward/common: - format.ts: USD/compact/gwei formatting + formatTokenAmount, including a regression test for the 0-decimal trailing-zero bug fixed in the prior commit. - address.ts: EVM checksum/validation, Solana base58 bounds, truncation. - spam.ts: isSpamToken known/spam-list short-circuits, name patterns, non-ASCII lookalikes (also documents the TLD-suffix pattern's known over-match). 25 new tests, all green via `pnpm --filter @chainward/common test`.
saltxd
force-pushed
the
fix/format-token-amount
branch
from
70c8ea8 to
b42183f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
formatTokenAmountran.replace(/\.?0+$/, '')unconditionally. For 0-decimal tokens,toFixed(0)yields an integer string ("100") and the strip ate real trailing zeros:"100" -> "1","1200" -> "12". The function is exported from@chainward/commonbut currently has zero call sites, so this fixes a latent display bug before first use.Fix + tests
format.ts(incl. a regression test for this bug),address.ts, andspam.ts.pnpm --filter @chainward/common test→ 32 passing.🤖 Generated with Claude Code