security: harden claude binary resolution#60
Merged
Conversation
Resolving the `claude` CLI path now validates every result before handing it to Command::new: - The login-shell fallback used an interactive login shell (`-lic`). Switch to a non-interactive login shell (`-lc`): we want the profile's PATH, not the side effects of interactive-only rc blocks. - The shell-resolved path and the `which` result are now both gated on `.is_file()`, matching the rigor the common-install-locations loop already applies. A stray line of shell output can no longer become the spawned binary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sam-powers
added a commit
that referenced
this pull request
Jun 13, 2026
Documents Quill's security posture for a reviewing engineer: the threat model (deep link as the one attacker-influenced entry point; deserialized data trusted more than rendered data), the four merged hardening measures (#57 path confinement + deep-link validation, #58 annotation sanitization, #59 URL scheme allowlists, #60 binary-resolution hardening), and the two deliberate non-fixes left in place with rationale (asset-protocol $HOME/** scope, remote-image beacon). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tightens how the
claudeCLI path is discovered before it's spawned, so a resolution step can never handCommand::newsomething that isn't a real executable.-lic). Switched to a non-interactive login shell (-lc): we want the profile's PATH, not the side effects of interactive-only rc blocks, and-ckeeps it to the singlecommand -vwe asked for.whichresult are now both gated on.is_file(), matching the rigor the common-install-locations loop already applies. A stray line of shell output can no longer become the spawned binary.No behavior change for a normally-installed CLI. Rust bar green:
cargo fmt --check,cargo clippy -D warnings,cargo test(27).🤖 Generated with Claude Code